HIVE-28770: Fix Downloaded Resources Directory Persisting After HiveServer2 Shutdown #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indhumathi27
force-pushed
the
resourcedir
branch
from
bc825d9 to
2975046
Compare
Indhumathi27
changed the title
Indhumathi27
force-pushed
the
resourcedir
branch
from
2975046 to
a57cb12
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Indhumathi27
force-pushed
the
resourcedir
branch
from
a57cb12 to
9fe84fb
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
Indhumathi27
force-pushed
the
resourcedir
branch
from
9fe84fb to
ae0e38c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensures hive.downloaded.resources.dir is properly cleaned up when HiveServer2 (HS2) shuts down. Adds cleanup logic to CliService.applyAuthorizationConfigPolicy and HiveMaterializedViewsRegistry.
Why are the changes needed?
Unused downloaded resources persist after HS2 shutdown, leading to disk bloat and performance degradation. This fix prevents unnecessary resource accumulation and improves cleanup.
Does this PR introduce any user-facing change?
No functional changes for users; it only enhances internal resource management. Temporary directories will now be cleaned up automatically.
Is the change a dependency upgrade?
No, this PR does not introduce any dependency upgrades.
How was this patch tested?
Manually verified that _resources directories are created and removed correctly.