Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" #19016

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

clarkwtc
Copy link
Contributor

@clarkwtc clarkwtc commented Feb 23, 2025

Follow-up #18880

Add "strict min ISR" description to improve MIN_IN_SYNC_REPLICAS_DOC

Before
Screenshot 2025-02-23 at 4 18 25 PM

After
Screenshot 2025-02-23 at 5 32 37 PM

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community clients small Small PRs labels Feb 23, 2025
@clarkwtc clarkwtc force-pushed the KAFKA-18849-add-strict-min-ISR-in-min-insync-replicas branch from 90c04cc to ec74a4f Compare February 23, 2025 09:34
"create a topic with a replication factor of 3, set <code>min.insync.replicas</code> to 2, and " +
"produce with <code>acks</code> of \"all\". This will ensure that the producer raises an exception " +
"if a majority of replicas do not receive a write.";
"this configuration specifies the minimum number of replicas that must acknowledge " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please fix the indent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved clients small Small PRs triage PRs from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants