[SPARK-51303] [SQL] [TESTS] Extend ORDER BY testing coverage
#50069
+435
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,24 @@ | |||
| -- Test data. | |||
| CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES | |||
There was a problem hiding this comment.
You should drop this view at the end of the test.
There was a problem hiding this comment.
We don't do that in any of the tests. @MaxGekk why is that?
| AS testData(a, b); | ||
|
|
||
| -- ORDER BY a column from a child's output | ||
| SELECT a FROM testData ORDER BY a; |
There was a problem hiding this comment.
We probably have these simple test cases somewhere already? I would be surprised if we don't.
| SELECT a, (SELECT b FROM testData GROUP BY b HAVING b > 1 ORDER BY a) FROM testData; | ||
|
|
||
| -- Column resolution from the child's output takes the precedence over `ORDER BY ALL` | ||
| SELECT a, (SELECT b FROM VALUES (1, 2) AS innerTestData (all, b) ORDER BY ALL) FROM testData; |
There was a problem hiding this comment.
This should be in order-by-all.sql, right?
There was a problem hiding this comment.
We don't resolve it as ALL keyword but as a column, that's why I put it here.
|
@MaxGekk Could you PTAL when you have time? Thanks |
mihailoale-db
force-pushed
the
addorderbygoldenfiles
branch
from
a0927af to
aff6f51
Compare
mihailoale-db
force-pushed
the
addorderbygoldenfiles
branch
from
aff6f51 to
061c8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I propose that we extend
order-by-all.sqlandDataFrameSuite.scalaand addorder-by.sqlwhich extend the coverage ofORDER BYfeature.Why are the changes needed?
In order to catch potential bugs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.