Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5439: Lua Generator: not support const i64 #2413

Closed
wants to merge 1 commit into from

Conversation

hkb1990
Copy link
Contributor

@hkb1990 hkb1990 commented Jul 5, 2021

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Jul 9, 2021

Some more information about the problem and why the patch solves it would be super awesome.

@hkb1990
Copy link
Contributor Author

hkb1990 commented Jul 9, 2021

Some more information about the problem and why the patch solves it would be super awesome.

described in jira ticket 5439.
const i64 is not generated correctly to lua. it is always generated to lualongnumber.new('') , no matter what value it is. Because t_base_type is i64, get_string returns empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants