Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5444 #2424

Closed
wants to merge 2 commits into from
Closed

THRIFT-5444 #2424

wants to merge 2 commits into from

Conversation

Jens-G
Copy link
Member

@Jens-G Jens-G commented Jul 31, 2021 •
edited
Loading

THRIFT-5444 Netstd generator produces uncompileable code for enums ending with "_result" or "_args"

Jens-G added 2 commits August 1, 2021 00:22
@Jens-G
THRIFT-5445 "cancellationToken" cannot be used as argument name
fea94d4 
Client: netstd
Patch: Jens Geyer
@Jens-G
THRIFT-5444 Netstd generator produces uncompileable code for enums en…
da1fd21 
…ding with "_result" or "_args"

Client: netstd
Patch: Jens Geyer
EnigmaTriton
EnigmaTriton approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@EnigmaTriton EnigmaTriton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what was done in this patch (thanks for the explanations on the history) and it works as expected. Looks good to me.

@Jens-G
Copy link
Member Author

Jens-G commented Aug 1, 2021

THRIFT-5445 still one missing, going to post separate PR and exclude it from this one.

@Jens-G Jens-G changed the title THRIFT-5445 and THRIFT-5444 THRIFT-5444 Aug 1, 2021
@Jens-G Jens-G closed this in 273607d Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnigmaTriton EnigmaTriton EnigmaTriton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jens-G @EnigmaTriton