Fix Windows build #2429

emmenlau · 2021-08-04T10:01:24Z

This PR hopefully improves the build on MSYS2, MINGW and adds support for MSVC2019.

Did you create an Apache Jira ticket? Not required for trivial changes.
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
Did you squash your changes to a single commit? (not required, but preferred)
Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

… class names

emmenlau · 2021-09-01T12:00:36Z

emmenlau force-pushed the bda_fix_win_build branch 19 times, most recently from 499c298 to e63c3f1 Compare August 5, 2021 19:43

emmenlau requested a review from Jens-G August 6, 2021 07:49

emmenlau added 9 commits August 11, 2021 19:25

Larger whitespace cleanup of AppVeyor build files

e14ac85

Renamed Windows build files from cl-prefix to win-prefix

9e3ac85

Updated MSYS2 install for current AppVeyor and upstream MSYS2

166786e

AppVeyor: larger updates in build configuration and documentation

ce64880

Removed the 'shortened' profile names in favor of descriptive profile…

22bb550

… class names

Separate the cmake 'build' and 'install' targets

c371e4a

Merged AppVeyor scripts for 'install', 'build' and 'test' into one

ffc7bb9

appveyor.yml: Disabled broken Cygwin build

fcb07b1

appveyor.yml: Disabled 'fast_finish'

6dfaf9c

emmenlau force-pushed the bda_fix_win_build branch from 07095e1 to 6dfaf9c Compare August 11, 2021 17:31

emmenlau merged commit 4cf1e35 into apache:master Aug 11, 2021

emmenlau deleted the bda_fix_win_build branch August 11, 2021 19:39

Provide feedback