Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5567: remove cl namespace references #2580

Merged
merged 1 commit into from
May 6, 2022
Merged

THRIFT-5567: remove cl namespace references #2580

merged 1 commit into from
May 6, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Apr 20, 2022 •
edited
Loading

warnings in build:

generate:
     [exec] [WARNING:/opt/thrift/src/tutorial/shared.thrift:26] No generator named 'cl' could be found!
     [exec] [WARNING:/opt/thrift/src/tutorial/tutorial.thrift:67] No generator named 'cl' could be found!
  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title remove cl namespace references THRIFT-5567: remove cl namespace references Apr 20, 2022
@jimexist jimexist force-pushed the remove-cl-namespace branch 2 times, most recently from f863e57 to ad70496 Compare April 27, 2022 11:46
@ctubbsii ctubbsii force-pushed the remove-cl-namespace branch from ad70496 to c88fe19 Compare May 5, 2022 20:28
@ctubbsii ctubbsii merged commit 45471de into apache:master May 6, 2022
@jimexist jimexist deleted the remove-cl-namespace branch May 6, 2022 04:57
m-g-r pushed a commit to m-g-r/thrift that referenced this pull request Aug 24, 2022
Revert "THRIFT-5567: remove cl namespace references (apache#2580)"
7b3d055 
This reverts commit 45471de.
@m-g-r m-g-r mentioned this pull request Aug 24, 2022
Closed
Jens-G pushed a commit that referenced this pull request Aug 30, 2022
@Jens-G
Revert "THRIFT-5567: remove cl namespace references (#2580)"
39fa185 
This reverts commit 45471de.
africamonkey pushed a commit to africamonkey/thrift that referenced this pull request Sep 14, 2022
@africamonkey
Revert "THRIFT-5567: remove cl namespace references (apache#2580)"
cc867bc 
This reverts commit 45471de.
africamonkey added a commit to africamonkey/thrift that referenced this pull request Sep 14, 2022
@africamonkey
Revert "Revert "THRIFT-5567: remove cl namespace references (apache#2580
51c2e6e 
)""

This reverts commit cc867bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimexist @ctubbsii