Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5570: update java lib document about gradle usage #2583

Merged
merged 3 commits into from
May 6, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Apr 21, 2022

update java lib document about gradle usage

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title update java lib document about gradle usage THRIFT-5570: update java lib document about gradle usage Apr 21, 2022
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good to me. I made only minor suggestions.

@jimexist
Copy link
Member Author

had to rebase to pickup fix from #2585

@ctubbsii ctubbsii force-pushed the java-doc-update branch from 6d43faf to 7af5cb9 Compare May 5, 2022 20:31
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc changes are fine, but I made a comment about the .gitignore files. I don't want to include the new .gitignore file here. I'd prefer to reconcile the differences with the one in the lib/kotlin directory and the root directory, and just merge it into the one at the root for consistency. Can be done as part of this PR, or a separate one. But, I don't think the new file should be added here.

@ctubbsii ctubbsii merged commit 23b8636 into apache:master May 6, 2022
@jimexist jimexist deleted the java-doc-update branch May 6, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants