-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5570: update java lib document about gradle usage #2583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes look good to me. I made only minor suggestions.
cf095aa
to
66cb534
Compare
had to rebase to pickup fix from #2585 |
66cb534
to
6d43faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc changes are fine, but I made a comment about the .gitignore files. I don't want to include the new .gitignore file here. I'd prefer to reconcile the differences with the one in the lib/kotlin directory and the root directory, and just merge it into the one at the root for consistency. Can be done as part of this PR, or a separate one. But, I don't think the new file should be added here.
update java lib document about gradle usage
[skip ci]
anywhere in the commit message to free up build resources.