Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: Add missing AC_CHECK_HEADERS #2610

Merged
merged 1 commit into from
May 23, 2022

Conversation

ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented May 21, 2022

Fix warnings running bootstrap.sh for the following by adding missing
entries in configure.ac:

configure.ac: warning: missing AC_CHECK_HEADERS([stdint.h]) wanted by: lib/rb/ext/binary_protocol_accelerated.c:22
configure.ac: warning: missing AC_CHECK_HEADERS([strings.h]) wanted by: lib/cpp/src/thrift/transport/TFileTransport.cpp:39

Sort all of the AC_CHECK_HEADERS lines, for easier readability in configure.ac

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Fix warnings running bootstrap.sh for the following by adding missing
entries in configure.ac:

```
configure.ac: warning: missing AC_CHECK_HEADERS([stdint.h]) wanted by: lib/rb/ext/binary_protocol_accelerated.c:22
configure.ac: warning: missing AC_CHECK_HEADERS([strings.h]) wanted by: lib/cpp/src/thrift/transport/TFileTransport.cpp:39
```

Sort all of the AC_CHECK_HEADERS lines, for easier readability in configure.ac
@ctubbsii ctubbsii force-pushed the fix-trivial-build-stuff branch from 8192c54 to fca5454 Compare May 21, 2022 19:50
@ctubbsii ctubbsii changed the title Trivial fixes: Add missing AC_CHECK_HEADERS Trivial: Add missing AC_CHECK_HEADERS May 21, 2022
@ctubbsii ctubbsii merged commit b90f2bc into apache:master May 23, 2022
@ctubbsii ctubbsii deleted the fix-trivial-build-stuff branch May 23, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants