Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '@types/graphql' since 'graphql' already includes TS typings #3724

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Remove '@types/graphql' since 'graphql' already includes TS typings #3724

merged 2 commits into from
Jan 27, 2020

Conversation

IvanGoncharov
Copy link
Member

graphql includes TS typings since 14.5.0 release.
@abernix Also without it you can't check TS definitions in 15.0.0, in #3712

@apollo-cla
Copy link

@IvanGoncharov: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@IvanGoncharov IvanGoncharov requested a review from abernix January 26, 2020 07:45
@abernix abernix added this to the 2.10.0 milestone Jan 27, 2020
@abernix
Copy link
Member

abernix commented Jan 27, 2020

Thanks, @IvanGoncharov!

@abernix abernix merged commit 902fefc into apollographql:master Jan 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants