Upgrade monorepo devDependencies to [email protected]
#4406
Conversation
This work is separated out from #4405, and is important to unblock progress on the new composition format. This upgrade could've happened at any time. Now that composition is being updated to a fork of the latest graphql schema printer, v15 is now a requirement. This comes with a few test updates, mostly around the sorting of AST nodes (i.e. in the query plan).
| @@ -683,7 +683,7 @@ Scenario: for abstract types, it should add __typename when fetching objects of | |||
| "kind": "Fetch", | |||
There was a problem hiding this comment.
@JakeDawkins at this point in time is it acceptable to be updating the .feature file like this? There should be no diff in the actual query plan itself, just in the ordering of some of the nodes.
|
It looks like the subscription tests are failing on Node 8 only |
|
@trevor-scheer Since we're already updating to Put another way, I don't believe we'll actually land this in 2.x because of the subscriptions tests which started failing similarly on past attempts to do a similar upgrade, e.g., - abernix/graphql-js-v15...abernix/graphql-js-v15-after-devDependency-gets-updated which I attempted/prepared as part of #3712 but never landed for the same subs reasons. |
This work is separated out from #4405, and is important tounblock progress on the new composition format.
This upgrade can happened at any time, leaving this open until we decide to move forward with v15 support.
This comes with a few test updates, mostly around the sorting
of AST nodes (i.e. in the query plan).