Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add android support #325

Merged
merged 1 commit into from
Sep 30, 2024
Merged

add android support #325

merged 1 commit into from
Sep 30, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Sep 26, 2024

Motivation:

Now that swift has an Android module, we should use it in swift-log to build for android.

Modifications:

Add Android imports where needed. This is specifically for Swift 6+.

Result:

I can build swift-log for android

@hyp hyp mentioned this pull request Sep 26, 2024
@hyp
Copy link
Contributor Author

hyp commented Sep 26, 2024

CC @FranzBusch

@hyp
Copy link
Contributor Author

hyp commented Sep 26, 2024

@swift-server-bot test this please

@compnerd
Copy link
Contributor

@swift-server-bot please test

@hyp
Copy link
Contributor Author

hyp commented Sep 27, 2024

CC @ktoso

@ktoso
Copy link
Member

ktoso commented Sep 30, 2024

@swift-server-bot test this please

Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks Alex!

@ktoso ktoso merged commit d032056 into apple:main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants