don't crash when client sends bad magic #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Aug 16, 2018
Sources/NIOHTTP2/HTTP2Parser.swift
Outdated
| @@ -126,12 +136,13 @@ fileprivate class ReentrancyManager { | |||
| } | |||
|
|
|||
| // Now we want to send some data. If this returns .continue, we want to spin | |||
| // around keep going. If this returns .complete, we can go ahead and flush. | |||
| if case .complete = body(.doOneWrite, ctx) { | |||
| // around keep going. If this returns .complete, we can go ahead and | |||
There was a problem hiding this comment.
You deleted a word from the comment.
There was a problem hiding this comment.
I must have discovered a new Xcode shortcut ;), sorry about that
|
This is also missing the linux tests. |
weissi
force-pushed
the
jw-dont-crash-on-bad-magic
branch
from
7329343 to
75624af
Compare
|
Cool, merge conflicts! |
Motivation: We shouldn't just crash if the client sends bad magic. Changes: Send an error through the pipeline instead of crashing on bad client magic. Result: fewer crashes
weissi
force-pushed
the
jw-dont-crash-on-bad-magic
branch
from
75624af to
b23154c
Compare
Lukasa
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We shouldn't just crash if the client sends bad magic.
Changes:
Send an error through the pipeline instead of crashing on bad client
magic.
Result:
fewer crashes