Update prism instrumentation #1172
Merged
+4,201
−2,031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to upgrade the prisma client, but first we need to update the TypeScript dependency to a more recent version. [skip changeset]
tombruijn
force-pushed
the
update-prism-instrumentation
branch
from
328e79b to
b3db466
Compare
|
Agent updated in #1174. This is now ready for review. |
|
✔️ All good! |
Update test apps to match the new trace structure by updating the span names and attributes. OpenTelemetry changed the `db.statement` span attribute to `db.query.text` in newer versions of their Semantic Conventions, so we'll need to update the attributes we sanitize in the extension/agent to match.
tombruijn
force-pushed
the
update-prism-instrumentation
branch
from
b3db466 to
930b3db
Compare
|
Nice work @tombruijn! |
unflxw
reviewed
Feb 21, 2025
unflxw
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Change itself seems okay. I'm unsure if this will break for users of older Prisma versions, and what we should do in that case.
If there's no good solution, maybe we need to consider removing automatic support for Prisma (so it's no longer our dependency) and changing the docs to ask customers to bring their own @prisma/instrumentation version and throw it at the additionalInstrumentations config option.
This comment has been minimized.
This comment has been minimized.
Fix mistyped named of the library. Co-authored-by: Noemi <[email protected]>
This is a message from the daily scheduled checks. |
luismiramirez
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TypeScript to version 5.7.x
We want to upgrade the prisma client, but first we need to update the TypeScript dependency to a more recent version.
Update Prism to 6.4 and test apps
Update test apps to match the new trace structure by updating the span names and attributes.
OpenTelemetry changed the
db.statementspan attribute todb.query.textin newer versions of their Semantic Conventions, so we'll need to update the attributes we sanitize in the extension/agent to match.To do
db.query.textattributes