fix: automatic put not triggered in Redux-Saga

[Mrxyy]

Description

When using Redux-Saga, calling yield call(fetchFeatureFlagsInit) does not automatically trigger put, resulting in the action not being dispatched to the Redux store.

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Improved the internal process for initializing feature settings by streamlining how updates are dispatched, ensuring a more controlled and consistent update flow within the application.

[coderabbitai]

Walkthrough

This pull request alters two saga functions to change how the fetchFeatureFlagsInit action is invoked. In one file, a forked task is replaced by a direct dispatch using put, while in another file, a blocking call is similarly replaced by put. These modifications change the control flow by dispatching the action to the Redux store, allowing the sagas to continue executing without waiting for the called operation to complete.

Changes

File(s)	Change Summary
app/client/src/ce/sagas/userSagas.tsx	Replaced yield fork(fetchFeatureFlagsInit); with yield put(fetchFeatureFlagsInit()); to dispatch the action directly in the saga's context.
app/client/src/sagas/EvaluationsSaga.ts	Updated yield call(fetchFeatureFlagsInit); to yield put(fetchFeatureFlagsInit()); so that the action is dispatched non-blocking, allowing subsequent saga actions to execute immediately.

Sequence Diagram(s)

sequenceDiagram
    participant Saga
    participant ReduxStore

    %% New control flow using put instead of fork/call
    Saga->>ReduxStore: put(fetchFeatureFlagsInit())
    ReduxStore-->>Saga: Processes action (non-blocking)

Loading

Possibly related PRs

• fix: Plugin Action Editor navigation issue with git #37670: Updates the dispatching of fetchFeatureFlagsInit from a blocking call to a non-blocking action using put.
• fix: fixing usage pulse for anon user #37940: Similar modifications in saga functions where the action is transitioned to be dispatched using put.
• fix: Saving status being stuck while moving between applications #35145: Changes the saga control flow from blocking calls to non-blocking action dispatch for fetchFeatureFlagsInit.

Suggested labels

Bug, Task, ok-to-test

Suggested reviewers

• hetunandu
• AmanAgarwal041

Poem

In the land of sagas where actions fly,
A dispatch whispers, “No time to lie!”
Forks and calls now step aside,
With put the action takes a joyful ride 🚀
Cheers to changes, smooth and snappy, side by side!

Happy coding!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b61634 and 9f910c5.

📒 Files selected for processing (2)

• app/client/src/ce/sagas/userSagas.tsx (1 hunks)
• app/client/src/sagas/EvaluationsSaga.ts (1 hunks)

🔇 Additional comments (2)

app/client/src/ce/sagas/userSagas.tsx (1)

184-184:

✅ Verification successful

LGTM! Improved Redux action flow.

The change from fork to put ensures the action properly flows through the Redux store and maintains consistency with other sagas.

Let's verify the Redux store receives and processes the action correctly:

---

🏁 Script executed:

#!/bin/bash
# Search for any other direct usage of fetchFeatureFlagsInit
rg "fetchFeatureFlagsInit\(" -A 2

Length of output: 710

---

LGTM! The change to use yield put(fetchFeatureFlagsInit()) in userSagas.tsx is consistent with similar patterns found in both EvaluationsSaga.ts and InitSagas.ts. This rewrite confirms that the Redux action now flows correctly through the store and aligns well with our overall saga implementations. Please ensure that downstream handling (i.e., processing of FETCH_FEATURE_FLAGS_SUCCESS) functions as expected.

app/client/src/sagas/EvaluationsSaga.ts (1)

765-765:

✅ Verification successful

LGTM! Consistent saga behavior.

The change from call to put aligns with the pattern in userSagas and ensures proper Redux store integration.

Let's verify the saga middleware handles both changes correctly:

---

🏁 Script executed:

#!/bin/bash
# Search for any saga middleware configuration that might affect action handling
rg "createSagaMiddleware|sagaMiddleware" -A 3

Length of output: 1690

---

LGTM! The change from call to put in EvaluationsSaga.ts (line 765) is consistent with the pattern in userSagas and integrates properly with our Redux saga middleware. The middleware configuration in store.ts (as verified by the shell script output) confirms that actions are handled correctly.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.