test: commenting tests with open bug for delete branch

[NandanAnantharamu]

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13419367493
Commit: b534037
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Wed, 19 Feb 2025 18:45:08 UTC

Summary by CodeRabbit

• Tests
  • Temporarily disabled internal tests related to branch deletion to reflect an identified issue. These adjustments ensure our quality checks remain aligned with current conditions without impacting your experience.

[coderabbitai]

Walkthrough

The changes update the Git delete branch test suite by marking two test cases as skipped due to an open bug. One test verifying branch deletion effects on the master branch and another ensuring that the default branch cannot be deleted are now inactive. The overall test suite structure remains unchanged.

Changes

File Path	Change Summary
app/.../Git/GitSync/DeleteBranch_spec.js	Marked two test cases as skipped: one for branch deletion validation and another for default branch deletion verification.

Possibly related PRs

• test: flaky check for published Spec #38427: Involves skipping test cases in a test suite due to similar bug issues.

Suggested labels

Bug, Test

Suggested reviewers

• ApekshaBhosale
• sagar-qa007
• brayn003

Poem

In our tests, a pause we now decree,
Bugs have spoken, it’s clear to see.
Branches wait in patient rest,
Until the fix is at its best.
Code flows onward with a merry zest!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d4f616 and b534037.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`app/client/cypress/**/**.*`: Review the following e2e test ...

app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

• app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js

🧠 Learnings (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js (1)

Learnt from: brayn003
PR: appsmithorg/appsmith#38635
File: app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/MergeViaRemote_spec.ts:102-102
Timestamp: 2025-01-13T15:14:12.806Z
Learning: In Cypress Git sync tests, explicit assertions after _.gitSync.SwitchGitBranch() are not required as the helper method likely handles the verification internally.

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js (1)

85-86: Well-documented test skipping.

Good practice to document the reason for skipping tests with a reference to the open bug.

Also applies to: 109-110

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.