-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #183
Comments
Here's my understanding of this but I don't know enough about the inner workings of Supercronic to confirm this is precise enough. Process reaping refers to the cleanup of zombie processes (defunct processes) that were created when a child process (a scheduled job) finished execution but was not properly waited on by its parent process. How It Happens: Why Reaping Matters: |
Just ignore it; reaping should only happen when the PID is 1. Changing the log level to 'info' would be more reasonable. |
1. change warn to info. The warning may confuse the user. 2. add document about reaping aptible#183
The README appears to be the only documentation for this software, and doesn't currently cover some key use cases.
(For example, I just tried supercronic for the first time and am seeing the warning "process reaping disabled, not pid 1" logged, but there is no mention in the docs of process reaping, the implications of having it disabled, what to do to enable it, etc. There is an unrelated mention that "Supercronic needs to be PID 1" to enable supercronic to reload crontabs when appropriate signals are delivered to the container, but again, no docs on or example of how to do that.)
Proposing this ticket to track improving the docs, ideally with a comprehensive description of supercronic's features, usage, and configuration available on a dedicated docs site, or at least in the README.
The text was updated successfully, but these errors were encountered: