-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize enum argument values in AddArgumentsAsVariables #1075
Conversation
@stefanprobst: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I think this fixes #1033. |
Would be amazing to have this merged asap! |
Any update on this? |
I tested this locally to stitch a couple of schemas, one with enum as arguments and it worked successfully. What is needed to merge this? |
This is fixed in graphql-tools-fork v6.0. |
@yaacovCR Works like a charm! Thank you! |
I hope this pull request will be merged asap. Without it, I can't use schema stitching. |
superseded by #1206 |
The
AddArgumentsAsVariables
transform currently takes the variable values directly fromargs
. This PR serializes allGraphQLEnumType
argument values before, so that the variable value contains the enum key, not the internal enum value. This avoids errors with merged schemas.Not sure if the same thing should also be done with custom scalars(???) I left those alone since I got a bit confused there - the
serialize
/parseValue
/parseLiteral
methods don't seem to be carried over in schema merging (becausekeepResolvers
will always befalse
inrecreateType
???)EDIT (07/18): This has been merged into
graphql-tools-fork
with additional fixes for custom scalars by @yaacovCR - thanks!