[release-v5] Next version of GraphQL Tools #1308
Conversation
|
We need this to not break TypeScript users apollographql/apollo-link#1262. Using |
= refactor makeRemoteExecutableSchema default resolvers to use delegateToSchema = return promise where required in createSubscriber = remove unused internal Delegator type
|
I might be missing something, but I bumped to Error [ERR_INVALID_PACKAGE_TARGET]: Invalid "exports" main target "index.cjs.js" defined in the package config .../node_modules/graphql-tools/package.jsonNote: I'm testing on a project running Node |
Using instanceOf causes problems is a project includes multiple versions of ApolloLink.
create separate folder of es utilities remove mergeDeep from exports (to match graphql-tools v4) es utilities do not require exporting
= do not rely on external, non-exported graphql-js types = provide backwards compatible ExecutionResult type that retains typecast from graphql-js <v15 = add extensions property from Result type to graphql-tools ExecutionResult type = use ExecutionResult type instead of Result = retain Result type for backwards-compatibility
= public types should be exported for ease of use = private types do not require aliases
= patch updates to apollo-link, tslib, and uuid = additional updates to devDependencies
|
@nohmar , are you able to share a reproducing minimal repository? |
|
@nohmar try |
|
@kamilkisiela @nohmar, package formats are beyond my pay grade, but the only thing I can think of for the underlying ERR_INVALID_PACKAGE_TARGET is that all the examples of exports field have a leading "./", see https://nodejs.org/api/esm.html#esm_package_entry_points Parenthetically, graphql-js seems to solve the problem of supporting esm/mjs builds just by emitting ".mjs" files for both, I wonder if this will work for us, too: see graphql/graphql-js#2379 I don't really understand the underlying issues related to package formats, so please excuse the above if it makes no sense at all. |
|
|
|
I did see that, am just curious, really... We may want to reference above when mjs graduates, I suppose. |
This PR will track the next version of
graphql-toolsand is lead by @kamilkisiela from The Guild and includes all fixes/features from @yaacovCR'sgraphql-tools-fork(which is merged into this PR).In order to use the new fixes, update
graphql-toolstonextor run:Please start using it today as share with us your feedback!
skipLibCheck: trueis a workaround, not a fix.