Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execution container no support noThrow option #60

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

JerrysShan
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Base: 96.29% // Head: 96.31% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (547958d) compared to base (4982a7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   96.29%   96.31%   +0.02%     
==========================================
  Files          12       12              
  Lines         351      353       +2     
  Branches       89       91       +2     
==========================================
+ Hits          338      340       +2     
  Misses         13       13              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/error.ts 100.00% <100.00%> (ø)
src/execution_container.ts 93.54% <100.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahziheng noahziheng merged commit a85d5a1 into artusjs:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants