Millisecond Block Time + Reduce Future Bound + Remove Block Cost

[patrick-ogrady]

Resolves: #244
Resolves: #182
Resolves: #247

Challenges

• Second-level granularity prevents a number of important data structures from getting too large -> leads to slight over-estimation of windows
• UX for configs easier to reason about in seconds

TODO

• store ms in block timestamp
• remove blockCost + blockCostWindow
• reduce future bound to 1s
• remove MaxBlockTxs
• add min block time to rules
• remove preferred blocks per second from config, just try to build as soon as min block time has surpassed using rules
• reduce tx/block precision for gas cost window + emap
• make block builder dynamic (don't just check every X ms)
• ensure GetValidityWindow is being used correctly
  • convert to ms to avoid multiplying by consts.MillisecondsPerSecond everywhere
  • need to wait for n+1 second before exiting during sync (otherwise may not get beginning of modulo range)? (as a simple example, consider a 500ms range -> missing first 500ms but other nodes will use those txs to determine if replay)
  • ensure oldest allowed lookback in blocks matches behavior in seen emap (non-determinism)
• add replay test where accept, then submit again to see if this is a bug
• [Different Approach] reduce precision of txs instead of truncating inner buckets (can assert as well in tx verification)
• clarify in a comment whether expiry time is inclusive
• Fix hang during E2E builder
  • Confirm that ProposerVM can handle millisecond timestamps (may need to truncate to second-level for it): https://github.com/ava-labs/avalanchego/blob/0ec52a9c6e5b879e367688db01bb10174d70b212/vms/proposervm/pre_fork_block.go#L201
  • We may need to just expose second-level granularity to the proposervm (which wouldn't break any invariants)

[patrick-ogrady]

Current log:

./node1-bls/logs/2Kr5MFwVZoAbaXL7u6NQBvMNMahKeokFfxj2An5eZvH3iFFztj.log:[07-19|22:36:54.606] DEBUG <2Kr5MFwVZoAbaXL7u6NQBvMNMahKeokFfxj2An5eZvH3iFFztj Chain> snowman/transitive.go:877 block verification failed {"error": "time must monotonically increase"}