[morpheus/token] vm limit cpu & disk usage #314
Conversation
|
I agree that we should make the number of nodes configurable (use args when running the program from the run script rather than hardcoding the change). You should avoid modifying the rate limit configs (those don't actually use/preallocate any CPU/disk). They just prevent the rate limiter from being active (not needed on a local network and can cause instability during stress tests -> still need to figure out recommended numbers for production). |
|
Configuring with less node generates error woth not enough amount staked. The only stuff related to the consensus I have seen for changing required staked amount is k and alpha parameters. |
I'm just referring to making the hardcoded values I have in the e2e tests ( ) a variable ( ).The consensus parameters are agnostic to the number of nodes actually in the subnet. You shouldn't have to modify any such params. |
|
This configures the subnets, but I would like to configure also the |
I wouldn't worry about that for now. They aren't really doing anything in the background here and should have very minimal CPU/RAM usage. If you still want to change that to "1" or something, you still wouldn't need to modify any consensus params. |
najeal
force-pushed
the
limit-cpu-disk-usage
branch
from
2d45368 to
5b2b251
Compare
|
@patrick-ogrady used vars as you suggested. |
| &numValidators, | ||
| "num-validators", | ||
| 5, | ||
| "number of validators by blockchain", |
| &numValidators, | ||
| "num-validators", | ||
| 5, | ||
| "number of validators by blockchain", |
| @@ -226,7 +235,7 @@ var _ = ginkgo.BeforeSuite(func() { | |||
|
|
|||
| // Name 5 new validators (which should have BLS key registered) | |||
| subnet := []string{} | |||
| for i := 1; i <= 5; i++ { | |||
| for i := 1; i <= int(numValidators); i++ { | |||
There was a problem hiding this comment.
going to check input is > 0
| @@ -221,9 +230,9 @@ var _ = ginkgo.BeforeSuite(func() { | |||
| // Name 10 new validators (which should have BLS key registered) | |||
| subnetA := []string{} | |||
| subnetB := []string{} | |||
| for i := 1; i <= 10; i++ { | |||
| for i := 1; i <= int(numValidators)*2; i++ { | |||
There was a problem hiding this comment.
going to check input is > 0
Few nits but otherwise looks great |
| @@ -165,6 +165,7 @@ var _ = ginkgo.BeforeSuite(func() { | |||
| gomega.Equal(modeFullTest), | |||
| gomega.Equal(modeRun), | |||
| )) | |||
| gomega.Expect(numValidators).Should(gomega.BeNumerically(">", 0)) | |||
Fixes #312
It looks weird to use
100000CPUs. I also deleted disk value to use the default one.