Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x/programs] add rust linter #368

Merged
merged 12 commits into from
Aug 21, 2023
Merged

[x/programs] add rust linter #368

merged 12 commits into from
Aug 21, 2023

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Aug 18, 2023

This PR adds a github action and fixes for linting rust using clippy via the latest nightly.

Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion hexfusion added this to the v0.2.0 (WASM Programs + Parallel Execution) milestone Aug 18, 2023
@hexfusion hexfusion linked an issue Aug 18, 2023 that may be closed by this pull request
@hexfusion hexfusion marked this pull request as ready for review August 18, 2023 12:41
Signed-off-by: Sam Batschelet <[email protected]>
@patrick-ogrady patrick-ogrady changed the title [ci]: add rust linter [x/programs] add rust linter Aug 18, 2023
@samliok samliok self-requested a review as a code owner August 20, 2023 22:23
samliok
samliok previously approved these changes Aug 20, 2023
Copy link
Contributor

@samliok samliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Signed-off-by: Sam Batschelet <[email protected]>
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on action

@samliok samliok requested a review from patrick-ogrady August 21, 2023 14:34
@patrick-ogrady patrick-ogrady merged commit b9b1edb into main Aug 21, 2023
@patrick-ogrady patrick-ogrady deleted the lint_rust branch August 21, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[x/programs] Add Rust Lint Action
3 participants