[x/programs] rewording for better dev ui #446

samliok · 2023-09-05T17:07:04Z

Changes

Context -> State
- methods implemented by Context are just changes to State
ProgramInvoke -> InvokeProgram
- Since we have get_map, set_map we should use invoke_program to follow the same phrasing style
Expose -> Public
- analogous to public functions in solidity
Removes the requirement for an init function if one is not needed.

richardpringle

Couple of small comments here

x/programs/rust/examples/counter/src/lib.rs

Cargo.toml

x/programs/rust/examples/counter/src/lib.rs

x/programs/rust/examples/token/Cargo.toml

x/programs/rust/wasmlanche_sdk/src/host/mod.rs

x/programs/rust/examples/token/src/lib.rs

richardpringle

Lookin' pretty slick!

Cargo.toml

x/programs/rust/examples/pokemon/src/lib.rs

x/programs/rust/wasmlanche_sdk/src/lib.rs

x/programs/examples/pokemon_test.go

x/programs/runtime/runtime.go

samliok added 4 commits September 5, 2023 11:50

Context -> State

96b2aed

programInvoke -> invokeProgram

4417d0e

expose -> public

ebd464b

remove mandatory init

af62b3e

samliok added run load labels Sep 5, 2023

samliok self-assigned this Sep 5, 2023

samliok requested review from hexfusion and patrick-ogrady as code owners September 5, 2023 17:07

lint

27635bc

richardpringle requested changes Sep 5, 2023

View reviewed changes

rename and expose macro from sdk

a5188fa

patrick-ogrady reviewed Sep 5, 2023

View reviewed changes

x/programs/rust/examples/token/src/lib.rs Show resolved Hide resolved

richardpringle previously approved these changes Sep 5, 2023

View reviewed changes

Cargo.toml Show resolved Hide resolved

x/programs/rust/examples/pokemon/src/lib.rs Outdated Show resolved Hide resolved

x/programs/rust/wasmlanche_sdk/src/lib.rs Show resolved Hide resolved

samliok added 2 commits September 5, 2023 22:42

lint + merge imports

8b75c9d

remove simulator

f8d9a07

samliok dismissed richardpringle’s stale review via f8d9a07 September 6, 2023 02:43

samliok added 2 commits September 5, 2023 23:26

rust lint test

c22a09f

remove server files

fbf069b

hexfusion reviewed Sep 6, 2023

View reviewed changes

x/programs/examples/pokemon_test.go Show resolved Hide resolved

x/programs/runtime/runtime.go Show resolved Hide resolved

x/programs/runtime/runtime.go Show resolved Hide resolved

x/programs/runtime/runtime.go Show resolved Hide resolved

samliok added 2 commits September 6, 2023 18:30

Merge branch 'main' of https://github.com/ava-labs/hypersdk

7390894

merge main

8ebdf7f

hexfusion approved these changes Sep 6, 2023

View reviewed changes

patrick-ogrady approved these changes Sep 6, 2023

View reviewed changes

patrick-ogrady merged commit 1820476 into main Sep 6, 2023

patrick-ogrady deleted the dev_ui branch September 6, 2023 23:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[x/programs] rewording for better dev ui #446

[x/programs] rewording for better dev ui #446

samliok commented Sep 5, 2023

richardpringle left a comment

richardpringle left a comment

[x/programs] rewording for better dev ui #446

[x/programs] rewording for better dev ui #446

Conversation

samliok commented Sep 5, 2023

richardpringle left a comment

Choose a reason for hiding this comment

richardpringle left a comment

Choose a reason for hiding this comment