-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[x/Programs] Dynamic Arguments #624
Conversation
…ugging stuff(will do this tmrw, its too late)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this a great step forward I have a few cosmetic things to review and in general would like to see the go tests moving to simulator but that can be a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
31ff2c7
Dynamic Arguments
This PR add support for non fixed length program function args. #576 .
Changes:
Program
type#[public]
functions are serialized usingborsh
.public
proc_macro was updated to callfrom_raw_pointer
on ptrs.example usage