-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generate-event): Add Kinesis Analytics events #667
Conversation
"shardId": "shardId-000000000001", | ||
"partitionKey": "partitionKey-01", | ||
"approximateArrivalTimestamp": 1505169657117, | ||
"sequenceNumber": "49571347871967966406409637155186850213682522142927749122" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--sequence
is in other Kinesis examples. Lets remain consistent across these events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, the KPL event in particular is special in that it's useful to have two records (one aggregated and one not), which raises the question of how we would parameterize these -- I can't see --data1
and --data2
being very nice, nor just one record being customizable.
However, the others are very similar so I've deduped them and made --data
a parameter (also now with encoding!).
"recordId": "49571347871967966406409637155186850213682522142927749122", | ||
"kinesisStreamRecordMetadata": { | ||
"shardId": "shardId-000000000001", | ||
"partitionKey": "partitionKey-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--partition-key
is in other Kinesis examples. Lets remain consistent across these events.
"approximateArrivalTimestamp": 1505169657117, | ||
"sequenceNumber": "49571347871967966406409637155186850213682522142927749122" | ||
}, | ||
"data": "84mawgoNMTUwNTE2OTY0NTI1MBIlODYwOTcwOTY1NTE0NjQwMzU1MjIwNTI5MjgyNDk2MzU3MTUzNxImNzk1MTM3MTQxMzM4MTE5NTU1OTExMzA1ODMxNDEyOTg2NTM2OTgaiAEIABAAGoEBNDAsYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWEKGogBCAAQARqBATQxLGFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhCkU/elbPye5g1wGkAmxGCNg=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--data
is in other Kinesis examples. Lets remain consistent across these events.
Please apply this across events.
Issue #, if available: NA
Description of changes: This adds 4 new events that work with the Kinesis Analytics blueprints. Although they are very similar, 4 are needed because the record data is encoded in different ways -- Base64 only, Base64-encoded DynamoDB record, .zip compressed, and aggregated via the KPL.
Ran the following tests:
I also took the generated events and invoked the Kinesis Analytics blueprints with them, and verified successful output.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.