Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates + "sam package" defaults to built template #775

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

sanathkr
Copy link
Contributor

Issue #, if available:

Description of changes:

  • sam init Python example README changes to include sam build
  • sam package command now just defaults to a built template. So you can do sam build && sam package --s3-bucket foo to build and then package. Don't need to manually wire the intermediate template files through.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sanathkr sanathkr requested a review from sriram-mv November 19, 2018 08:00
@heitorlessa
Copy link
Contributor

heitorlessa commented Nov 19, 2018 via email

@sanathkr sanathkr merged commit 5cd2b67 into aws:develop Nov 19, 2018
@mvanbaak
Copy link
Contributor

It just keeps getting better!

Thanks again!

@mvanbaak
Copy link
Contributor

sam package output should still be sent to a packaged template that can be given to sam deploy right?
Or did I miss something?

@sanathkr
Copy link
Contributor Author

You are right. We need to change that as well. One step at a time :-)

@mvanbaak
Copy link
Contributor

of course, just wanted to check. Keep up the good work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants