Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove python3.8 from integ tests #7862

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

valerena
Copy link
Contributor

@valerena valerena commented Feb 5, 2025

We removed support for python3.8 in AppVeyor instances.

The runtime is deprecated in Lambda already, but it's still partially supported (that's why we're not removing it completely)

There are still some unit tests using python3.8, that we can remove those in the future.

Which issue(s) does this change fix?

Test failures

Why is this change necessary?

Our AppVeyor instances that run integration tests don't have Python3.8 configured anymore.

How does it address the issue?

We don't run the integration tests that need to use python3.8 in the environment.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We removed support for python3.8 in AppVeyor instances.

The runtime is deprecated in Lambda already, but it's still partially
supported (that's why we're not removing it completely)
@valerena valerena requested a review from a team as a code owner February 5, 2025 00:15
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Feb 5, 2025
@seshubaws
Copy link
Contributor

some lint error

mypy --exclude /testdata/ --exclude /init/templates/ --no-incremental setup.py samcli tests schema
tests/unit/local/docker/test_lambda_image.py:338: error: closing parenthesis ')' does not match opening parenthesis '[' on line 336  [syntax]
Found 1 error in 1 file (errors prevented further checking)
make: *** [lint] Error 2

@valerena valerena added this pull request to the merge queue Feb 5, 2025
Merged via the queue into aws:develop with commit 0287934 Feb 5, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants