Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): cleanup build containers #929

Merged
merged 3 commits into from
Jan 14, 2019
Merged

fix(build): cleanup build containers #929

merged 3 commits into from
Jan 14, 2019

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Jan 10, 2019

Issue #, if available:
#859

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss jfuss requested a review from sriram-mv January 10, 2019 21:52
sriram-mv
sriram-mv previously approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jfuss jfuss changed the base branch from develop to master January 14, 2019 15:55
@jfuss jfuss changed the base branch from master to develop January 14, 2019 15:55
@jfuss
Copy link
Contributor Author

jfuss commented Jan 14, 2019

Well changing the target branch didn't work...

Github says Travis hasn't completed but going to the build, Travis shows it as passed.

@jfuss jfuss merged commit 528e219 into aws:develop Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keetonian keetonian keetonian approved these changes

@sriram-mv sriram-mv sriram-mv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfuss @sriram-mv @keetonian