Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Add TLS support #2753

Merged
merged 7 commits into from
Jun 10, 2020
Merged

Conversation

joancafom
Copy link
Contributor

Traffic between cluster nodes can now be secured with the use of TLS.
Signed-off-by: joancafom [email protected]

Description of the change
Included envars and configuration so as to make the nodes use TLS.

Benefits
Traffic between nodes can be secured

Possible drawbacks
TLS and Prometheus Metrics can not work together. This is an outgoing issue for Redis Metrics Exporter.

Applicable issues

NA

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@andresbono andresbono self-requested a review June 5, 2020 08:45
Copy link
Contributor

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please run the proper CI/CD job to update the image tags.

Jose Antonio Carmona and others added 2 commits June 10, 2020 12:18
@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/redis:6.0.5-debian-10-r1"
  • "docker.io/bitnami/redis-exporter:1.6.1-debian-10-r27"
  • "docker.io/bitnami/redis-sentinel:6.0.5-debian-10-r0"
  • "docker.io/bitnami/minideb:buster"
  • "docker.io/bitnami/minideb:buster"

@joancafom joancafom merged commit bc85818 into bitnami:master Jun 10, 2020
@joancafom joancafom mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants