Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping nbQA from .pre-commit-config.yaml #1064

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Dropping nbQA from .pre-commit-config.yaml #1064

merged 4 commits into from
Aug 21, 2024

Conversation

tkoyama010
Copy link
Collaborator

@tkoyama010 tkoyama010 commented Aug 20, 2024

🚀 Pull Request

Description


Ruff start to Lint and format Jupyter Notebook by default (astral-sh/ruff#12878) from v0.6.0. We can drop using nbQA.

@tkoyama010 tkoyama010 requested a review from bjlittle as a code owner August 20, 2024 22:58
@github-actions github-actions bot added the type: infrastructure Auto-labelled label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (e5d14f5) to head (da61753).
Report is 138 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          58       58           
  Lines        2936     2936           
=======================================
  Hits         2680     2680           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tkoyama010 tkoyama010 enabled auto-merge (squash) August 21, 2024 01:22
Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoyama010 Awesome, thanks 🎉

Would you like to add a changelog news fragment too?

i.e., changelog/1064.internal.rst

@tkoyama010 tkoyama010 requested a review from bjlittle August 21, 2024 08:06
@tkoyama010 tkoyama010 requested a review from bjlittle August 21, 2024 10:47
@bjlittle bjlittle disabled auto-merge August 21, 2024 10:52
@bjlittle bjlittle merged commit df4d5db into main Aug 21, 2024
23 checks passed
@bjlittle bjlittle deleted the maint/drop-nbqa branch August 21, 2024 10:59
bjlittle added a commit that referenced this pull request Sep 6, 2024
bjlittle added a commit that referenced this pull request Sep 6, 2024
bjlittle added a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants