Declared global variables treated as undefined

[assaf]

In JavaScript, this results in an ReferenceError: y is not defined:

x = y

OTOH a variable declared with no value is set to undefined, and so this sets x to undefined:

var y
x = y

This pull requests provides two tests, one with a sandbox property (x) set to undefined and one with a global variable (z) declared as undefined.

This seems to fix the first test, by returning the sandbox property if defined, regardless of value:

Local<Value> rv = sandbox->Get(property);
if (sandbox->HasRealNamedProperty(property))
    return scope.Close(rv);

// Next, check the global object (things like Object, Array, etc).
// This needs to call GetRealNamedProperty or else we'll get stuck in
// an infinite loop here.
rv = info->global->GetRealNamedProperty(property);

I am not sure if this is correct, or how to go about fixing the second test.

[brianmcd]

Thanks for the tests and the detailed report. I merged the tests in and I think I fixed the issue. If it looks good to you, I'll push a new release to npm. I tried running the Zombie (with the pending test activated) and JSDOM test suites with these fixes, and everything seems normal.

Thanks again for digging into this.

[assaf]

Sweet. Works like a charm!

[brianmcd]

I just pushed version 0.0.7 to npm. Thanks for your help on this!

[assaf]

And Zombie 0.12.3 is out. Thank you so much for making that possible.

On Tuesday, December 13, 2011 at 10:47 AM, Brian McDaniel wrote:

I just pushed version 0.0.7 to npm. Thanks for your help on this!

---

Reply to this email directly or view it on GitHub:
#11 (comment)

[brianmcd]

Glad to help!