Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Fix: Build error '-arch' on OSX Lion #20

Closed
wants to merge 2 commits into from
Closed

Fix: Build error '-arch' on OSX Lion #20

wants to merge 2 commits into from

Conversation

txgruppi
Copy link

No description provided.

@brianmcd
Copy link
Owner

brianmcd commented Mar 2, 2012

Can you post the build error you're running into?

I don't have a mac to test anything on, so it'd be helpful to understand what you're fixing. It looks like this would remove the -O3 flag for all non-Darwin < 10.7 systems, which is probably something we don't want. The arch check is in response to this issue: #19 so we can build the addon as 32-bit if there's a 32-bit Node installed on a 64-bit machine (and the default Mac installer installs a 32-bit Node regardless of the host architecture). I think this patch would break that fix (but definitely correct me if I'm wrong - I don't know much about Macs), so hopefully we can come up with a solution that works for everyone.

I definitely want to fix the build if it's breaking for you, but just want to make sure nothing else breaks since I can't test this myself.

@txgruppi
Copy link
Author

txgruppi commented Mar 2, 2012

Hi,

I made a mistake.

I just want to remove the -arch argument from the build command. Its the problem in OSX 10.7+

If you want I can start remote session for you with www.mikogo.com.br in 2 hours from now

PS: Sorry about some english mistakes.

@txgruppi
Copy link
Author

txgruppi commented Mar 9, 2012

Any comment?

@brianmcd
Copy link
Owner

Sorry! I've been out of town this past week. Sending you a message now.

@brianmcd
Copy link
Owner

Closed in cf362c1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants