Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu::intel: Do CPU feature detection in Rust. #2346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

briansmith
Copy link
Owner

No description provided.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 88.42105% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.61%. Comparing base (e5fe160) to head (86837a3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/cpu/intel.rs 88.42% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2346   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         176      175    -1     
  Lines       21640    21605   -35     
  Branches      529      515   -14     
=======================================
- Hits        20907    20874   -33     
- Misses        618      626    +8     
+ Partials      115      105   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith force-pushed the b/fxsr-3 branch 4 times, most recently from 45b3569 to 4ab4ec6 Compare February 9, 2025 04:20
@briansmith
Copy link
Owner Author

It looks like Rust 1.63..=1.65 may contain bugs in __cpuid: rust-lang/rust#101861 so we may need to vendor a newer version of __cpuid or do another workaround.

@briansmith briansmith force-pushed the b/fxsr-3 branch 2 times, most recently from b497019 to 411cb9d Compare February 9, 2025 06:25
@briansmith
Copy link
Owner Author

It looks like Rust 1.63..=1.65 may contain bugs in __cpuid: rust-lang/rust#101861 so we may need to vendor a newer version of __cpuid or do another workaround.

We should check what the latest versions of stdarch do and what libstd is using. Maybe we can look into workarounds used by other projects to use these safely.

@briansmith
Copy link
Owner Author

briansmith commented Feb 9, 2025

This has two commits; the first is PR #2352. When PR #2352 gets merged, I will rebase this.

[Edit: Rebased]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant