fix to decrement open connections count on connect exception #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks good to me but I think we'll obv want to test it in stage with an existing service (like flexpro_api) to make sure it a) solves the problem we're trying to solve and b) doesn't create any other weird behavior. |
|
@benjsto agreed. Can you pull it in to flexpro, push it and we can test? |
|
I can do that. Won't get to that until Monday most likely.. |
dangnvang
reviewed
Apr 7, 2017
tornado_mysql/pools.py
Outdated
|
|
||
| # Wait to other connection is released. | ||
| fut = Future() | ||
| self._waitings.append(fut) | ||
| return fut | ||
|
|
||
| def _on_connect(self, fut): | ||
| logging.info('error') |
There was a problem hiding this comment.
Looks like this should be inside the if block below?
There was a problem hiding this comment.
thanks @dangnvang will just remove it.
|
@benjsto: I'll take a shot at a PR for flexpro |
|
Thanks Dang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the pool connection count in incremented even if their is an error while creating the connection. Based on an earlier PR that was never merged.