Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded nightly features and improve documentation #184

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

Alonely0
Copy link
Contributor

@Alonely0 Alonely0 commented Jul 1, 2023

This PR removes some unnecessary feature flags that were stabilized or easily replaceable, and has merged the scattered module-level documentation across the repo.

Alonely0 added 2 commits July 1, 2023 02:57
Some were unneeded, others were easily replaceable.
@ihciah
Copy link
Member

ihciah commented Jul 3, 2023

Thanks for your contribution! The reason for adding #![allow(stable_features)] is to provide partial compatibility for old nightly toolchains(indeed some of them can be removed).

@Alonely0
Copy link
Contributor Author

Alonely0 commented Jul 3, 2023

Thanks for your contribution! The reason for adding #![allow(stable_features)] is to provide partial compatibility for old nightly toolchains(indeed some of them can be removed).

Oh, fair enough. It's fixed now. Can you run the CI again? I have no idea why it is failing, it works on my machine.

@ihciah
Copy link
Member

ihciah commented Jul 4, 2023

I have no idea why it is failing

Nerver mind, we can fix it later. Thanks!

@ihciah ihciah merged commit ae2fcbc into bytedance:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants