ci: Disable test for i686 unknown linux target #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Lzzzzzt, I think it's fine to disable the test for now. What do you think? |
|
same with you. |
|
Thanks to @Lzzzzzt's efforts, our CI passed ALL for the first time in five months! |
|
Looks good. Disable i686 to pass the CI can expose problems for other PRs instead of making it a burdern or waste. |
ihciah
approved these changes
Aug 7, 2024
renovate bot
referenced
this pull request
in spiraldb/vortex
Aug 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [monoio](https://togithub.com/bytedance/monoio) | workspace.dependencies | patch | `0.2.3` -> `0.2.4` | --- ### Release Notes <details> <summary>bytedance/monoio (monoio)</summary> ### [`v0.2.4`](https://togithub.com/bytedance/monoio/releases/tag/0.2.4) [Compare Source](https://togithub.com/bytedance/monoio/compare/0.2.3...0.2.4) #### What's Changed - readme: typo fix by [@​tshepang](https://togithub.com/tshepang) in [https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258) - enhance: remove redundant check and improve efficiency by [@​ihciah](https://togithub.com/ihciah) in [https://github.com/bytedance/monoio/pull/260](https://togithub.com/bytedance/monoio/pull/260) - fix: read_u128\_le() returns u16 instead of u128 . by [@​liuxin231](https://togithub.com/liuxin231) in [https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262) - Fix docs.rs build by [@​hatoo](https://togithub.com/hatoo) in [https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264) - Feat: BoxFuture which implements Send by [@​har23k](https://togithub.com/har23k) in [https://github.com/bytedance/monoio/pull/271](https://togithub.com/bytedance/monoio/pull/271) - ci/fix: modify ci.yml to let `cargo fmt/clippy` only runs on nightly channel by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273) - feat(op, fs): ✨ Intergated `statx` into monoio by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/268](https://togithub.com/bytedance/monoio/pull/268) - ci: Make rustfmt and clippy happy by [@​Xuanwo](https://togithub.com/Xuanwo) in [https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279) - docs: correct JoinHandle link in the doc of spawn() by [@​SteveLauC](https://togithub.com/SteveLauC) in [https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265) - ci: using main branch of cross by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/283](https://togithub.com/bytedance/monoio/pull/283) - make clippy happy by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/284](https://togithub.com/bytedance/monoio/pull/284) - ci: Disable test for i686 unknown linux target by [@​Xuanwo](https://togithub.com/Xuanwo) in [https://github.com/bytedance/monoio/pull/286](https://togithub.com/bytedance/monoio/pull/286) - fix: don't register file fd in `File::from_std` by [@​NKID00](https://togithub.com/NKID00) in [https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277) - feat(op, fs): ✨ add `MkDirAt` opcode in io-uring and `create_dir(_all)` by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/270](https://togithub.com/bytedance/monoio/pull/270) - feat: unlink op, remove_file and remove_dir by [@​NKID00](https://togithub.com/NKID00) in [https://github.com/bytedance/monoio/pull/288](https://togithub.com/bytedance/monoio/pull/288) - feat: support `opcode::RenameAt` by [@​Lzzzzzt](https://togithub.com/Lzzzzzt) in [https://github.com/bytedance/monoio/pull/289](https://togithub.com/bytedance/monoio/pull/289) #### New Contributors - [@​tshepang](https://togithub.com/tshepang) made their first contribution in [https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258) - [@​liuxin231](https://togithub.com/liuxin231) made their first contribution in [https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262) - [@​hatoo](https://togithub.com/hatoo) made their first contribution in [https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264) - [@​Lzzzzzt](https://togithub.com/Lzzzzzt) made their first contribution in [https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273) - [@​Xuanwo](https://togithub.com/Xuanwo) made their first contribution in [https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279) - [@​SteveLauC](https://togithub.com/SteveLauC) made their first contribution in [https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265) - [@​NKID00](https://togithub.com/NKID00) made their first contribution in [https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277) **Full Changelog**: bytedance/monoio@0.2.3...0.2.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/spiraldb/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ihciah
i686_unknown_linux_gnuis the only target that fails the test. Considering there are few i686 instances globally, I believe it's reasonable to drop this test for now. We can reintroduce it if someone is willing to address #285.