Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn must the same package as language definition. #1325

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

dz0ny
Copy link
Contributor

@dz0ny dz0ny commented Jul 8, 2024

Inherit a package, so that we do not end up with different versions of Node.js as default is whatever is marked as stable in Nixpkgs.

dz0ny added 2 commits July 9, 2024 00:10
…f Node.js as default is whatever is marked as stable in Nixpkgs.
@domenkozar
Copy link
Member

error: syntax error, unexpected '=', expecting ';'

@domenkozar
Copy link
Member

@domenkozar
Copy link
Member

Ping

@dz0ny
Copy link
Contributor Author

dz0ny commented Aug 20, 2024

We ended with a configuration like this, but this is mostly because the project uses a lot of packages and there were issues with resolving correct ESM/non-ESM packages that older versions of Yarn had.

{
  inputs,
  ...
}: let
  nixpkgs-2405 = import inputs.nixpkgs-2405 {system = pkgs.stdenv.system;};
  node-20 = nixpkgs-2405.nodejs_20;
  yarn-422 = nixpkgs-2405.yarn-berry.override {
    nodejs = node-20;
  };
in {
  packages = with nixpkgs-2405; [
    yarn-422
    node-20
  ];
  languages.javascript.package = node-20;
}

@domenkozar
Copy link
Member

Let's wait on the CI

@domenkozar
Copy link
Member

@dz0ny can you rebase?

@domenkozar domenkozar merged commit 5b48219 into cachix:main Sep 30, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants