Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't delete runtime dir on process down #1366

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: don't delete runtime dir on process down #1366

merged 1 commit into from
Aug 8, 2024

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Aug 8, 2024

Fixes #1270.

@domenkozar, should we be deleting the runtime dir when taking down processes? Any good reason to do this?

There are a few issues with this line:

  1. It relies on trapping a signal. In the case of process-compose, I think the reason it's immune from this failure is because the trap is never triggered. We need to rethink how we run post-process actions.
  2. We create the runtime dir in the CLI, but try to delete it in the shell script. This sounds like a bug magnet to me.
  3. There was an issue a while back where redis would crash on shutdown because of a race condition here.

@sandydoo sandydoo added the bug Something isn't working label Aug 8, 2024
@domenkozar
Copy link
Member

Maybe instead we should delete it on startup? To start fresh?

@sandydoo
Copy link
Member Author

sandydoo commented Aug 8, 2024

Maybe instead we should delete it on startup? To start fresh?

do we care?

@domenkozar domenkozar merged commit 6e31885 into main Aug 8, 2024
269 of 276 checks passed
@mpscholten
Copy link
Contributor

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

second devenv up always crashes with overmind
3 participants