fix(remotebuild): use build-on archs #5265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3280-cross-compiles
branch
from
d417958 to
18856a8
Compare
lengau
requested changes
Feb 20, 2025
Comment on lines
+107
to
+112
| <<<<<<< HEAD | ||
| - `#4996`_ Remote build gives an unfriendly error when attempting to cross-compile. | ||
| ======= | ||
| - `#5258`_ The Flutter plugin fails to install Flutter for ``core22`` and ``core24`` | ||
| snaps. | ||
| >>>>>>> d4179581e (docs: add remote-build changes) |
There was a problem hiding this comment.
Is this file supposed to be here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?make test?This PR updates Snapcraft to pass
build-onarchitectures to Launchpad rather than thebuild-forarchitectures. It updates the spread tests to exercise this.Benefits:
build-for: [all]would build onamd64. Now it builds on one of thebuild-onarchitectures in thesnapcraft.yaml.This is possible due to the following constraints:
build-onarchitecture.Spread tests: https://github.com/canonical/snapcraft/actions/runs/13401419675
Fixes #4996
(CRAFT-3280)