Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eds: make Size method return error #4091

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

The Size method in the eds.Accessor interface now returns an error to handle cases where:

  • The header is not initialized in ODS
  • The extended data square is not initialized in Rsmt2D
  • The accessor is closed in closeOnce

This change makes the interface more consistent with other methods that return errors
and allows proper error handling in cases where size information cannot be retrieved.

Updates:

  • eds.Accessor interface to include error in Size method signature
  • All implementations (ODS, ODSQ4, Rsmt2D, NoopFile, validation, proofsCache, closeOnce)
  • Tests and mocks to handle the error return

Resolves TODO in store/file/ods_q4.go about Size method returning error.

@github-actions github-actions bot added the external Issues created by non node team members label Feb 5, 2025
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution

@VolodymyrBg VolodymyrBg requested a review from walldiss February 11, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants