Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/celestia): Split subcommands into full subcommands and auxiliary #4131

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Feb 18, 2025

All subcommands were inheriting the same flagsets + parsing logic even though 4/6 subcommands only need access to --node.store and --p2p.network.

This splits logic such that only the necessary flags + parsing logic are added to auxiliary subcommands.

This also resolves #4063

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 8.24742% with 89 lines in your changes missing coverage. Please review.

Project coverage is 45.05%. Comparing base (2469e7a) to head (661e7ab).
Report is 443 commits behind head on main.

Files with missing lines Patch % Lines
cmd/node.go 0.00% 22 Missing ⚠️
cmd/util.go 0.00% 20 Missing ⚠️
cmd/flags_node.go 0.00% 15 Missing ⚠️
nodebuilder/p2p/flags.go 0.00% 15 Missing ⚠️
cmd/config.go 0.00% 6 Missing ⚠️
cmd/init.go 0.00% 4 Missing ⚠️
cmd/auth.go 0.00% 3 Missing ⚠️
cmd/reset_store.go 0.00% 3 Missing ⚠️
cmd/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4131      +/-   ##
==========================================
+ Coverage   44.83%   45.05%   +0.21%     
==========================================
  Files         265      308      +43     
  Lines       14620    22571    +7951     
==========================================
+ Hits         6555    10169    +3614     
- Misses       7313    11313    +4000     
- Partials      752     1089     +337     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay changed the title fix(cmd/celestia): Split prerun commands into only those necessary fo… fix(cmd/celestia): Split subcommands into full subcommands and auxiliary Feb 19, 2025
@renaynay renaynay added the kind:fix Attached to bug-fixing PRs label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
3 participants