Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned Git Processes #262

Closed
m13t opened this issue May 5, 2023 · 2 comments · Fixed by #263
Closed

Orphaned Git Processes #262

m13t opened this issue May 5, 2023 · 2 comments · Fixed by #263
Labels
bug Something isn't working docker

Comments

@m13t
Copy link
Contributor

m13t commented May 5, 2023

Describe the bug
I've just been investigating my git server which has fallen over twice since upgrading to the latest version. It seems that every time someone connects via SSH or doing a clone, pull etc. the spawned git process by soft-serve is being left behind and reported as defunct when doing a ps -ef in the container, which is also visible on the host. These processes whilst not utilising any CPU or memory, are causing the server to grind to a complete halt, causing me to have to force reboot the system.

To Reproduce
Steps to reproduce the behavior:

  1. Start soft-serve listening in a docker container
  2. Connect and disconnect via ssh or git clone
  3. Observe orphaned system git processes

Expected behavior
Git processes should be properly terminated once soft-serve has finished invoking them.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: Alpine Linux on x86 server and Docker Desktop on Mac
  • Version v0.5.1

Additional context
N/A

@aymanbagabas aymanbagabas added bug Something isn't working docker labels May 5, 2023
aymanbagabas added a commit that referenced this issue May 5, 2023
We have to wait for exec.Command to exit

Fixes: #262
aymanbagabas added a commit that referenced this issue May 5, 2023
We have to wait for exec.Command to exit

Fixes: #262
@aymanbagabas
Copy link
Member

Thank you @m13t for taking the time to report this one. This is now fixed in c93630e and released in v0.5.2

@m13t
Copy link
Contributor Author

m13t commented May 5, 2023

Thanks @aymanbagabas. I've rolled this out and can confirm this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants