Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): respect log config #280

Merged
merged 2 commits into from
May 11, 2023
Merged

fix(log): respect log config #280

merged 2 commits into from
May 11, 2023

Conversation

aymanbagabas
Copy link
Member

Parse log config

caarlos0
caarlos0 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I noticed this too, was about to start working in it as well.

thanks!

Base automatically changed from ui-regs to main May 11, 2023 19:47
@aymanbagabas
fix(log): respect log config
4e014df 
Parse log config

fix(git): ensure os envs are present

feat: set the default time format to dateTime

fix(log): change update mirror log message into debug

fix(config): rename log config struct

fix(config): always return cfg
@aymanbagabas @caarlos0
perf: update mirrors in a workpool (#285)
f30b99a 
* perf: update mirrors in a workqueue

Implement a simple chunked workqueue to queue updating mirrors. We use
the number of cpus to calculate the number of workers to distribute the
work to.

* fix: use automaxprocs

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: set maxprocs in main

* feat(wp): use a workpool impl

Use semaphores to implement a workpool of n workers
and use that to run the mirroring job

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Co-authored-by: Carlos Alexandro Becker <[email protected]>
@aymanbagabas aymanbagabas merged commit b07de74 into main May 11, 2023
@aymanbagabas aymanbagabas deleted the log-config branch May 11, 2023 20:02
aymanbagabas added a commit that referenced this pull request May 15, 2023
@aymanbagabas
fix(server): possible panic using maps
a9e4824 
use a sync.Map to avoid possible panic on concurrent map iteration and
map write

Fixes: b07de74 ("fix(log): respect log config (#280)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @caarlos0