Avoid gathering all data with sysctl which seems to hang #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
approved these changes
Sep 27, 2018
spec/unit/plugins/darwin/cpu_spec.rb
Outdated
| @@ -78,7 +78,7 @@ | |||
| CTL | |||
|
|
|||
| allow(@plugin).to receive(:collect_os).and_return(:darwin) | |||
| allow(@plugin).to receive(:shell_out).with("sysctl -a").and_return(mock_shell_out(0, @stdout, "")) | |||
| allow(@plugin).to receive(:shell_out).with("sysctl cpu machdep").and_return(mock_shell_out(0, @stdout, "")) | |||
There was a problem hiding this comment.
The code runs sysctl hw and the test expects sysctl cpu - looks like the source of the failures
tyler-ball
force-pushed
the
sysctl_less
branch
from
93245f2 to
1e63bb3
Compare
|
@tas50 Updated the spec to match |
cheeseplus
approved these changes
Sep 27, 2018
While it works fine for me @bdausses was seeing chef-client hang forever. It turns out running sysctl -a on his host was causing the system to hang. Besides this crash it actually takes about 2x longer to gather the additional data. This shaves a whole 0.033255 seconds from the total runtime. Signed-off-by: Tim Smith <[email protected]>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it works fine for me @bdausses was seeing chef-client hang
forever on macos 10.14. It turns out running sysctl -a on his VM was causing the
system to hang. Besides this crash it actually takes about 2x longer to
gather the additional data, which we never use. This shaves a whole 0.033255 seconds from
the total runtime of Ohai.
Signed-off-by: Tim Smith [email protected]