Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed 'whitelist' to 'allowlist' in DMI plugin #1522

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Renamed 'whitelist' to 'allowlist' in DMI plugin #1522

merged 1 commit into from
Oct 12, 2020

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Oct 1, 2020

Description

Deprecate whitelist and replace with allowlist. Use the deprecation syntax to keep the old method alive - but marked as deprecated.

Related Issue

Fixes #1458

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vraravam vraravam requested review from a team as code owners October 1, 2020 16:27
@tas50
Copy link
Contributor

tas50 commented Oct 12, 2020

@vraravam Can you revert the parts that change the changelog and the release notes. Those are historic documents and need to have the original names.

@vraravam
Copy link
Contributor Author

done @tas50 - please re-verify

@tas50 tas50 changed the title Renamed 'whitelist' to 'allowlist' and 'blacklist' to 'denylist' Renamed 'whitelist' to 'allowlist' in DMI plugin Oct 12, 2020
@tas50 tas50 merged commit 0bb36d0 into chef:master Oct 12, 2020
@tas50
Copy link
Contributor

tas50 commented Oct 12, 2020

Thanks for fixing this up

@vraravam vraravam deleted the deprecate-color-biased-methods branch October 13, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using whitelist / backlist terms
2 participants