[block_device] Record firmware revision of nvme block devices

[saravan2]

Enhancing the plugin to record the firmware of nvme block devices

Description

The sysfs end point for firmware in nvme block device differs from HDD. Added firmware_rev to the plugin check list to collect this information on servers with nvme block devices.

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dafyddcrosby]

Confirmed https://github.com/torvalds/linux/blob/master/drivers/nvme/host/core.c#L3554 and my laptop (Fedora 37, 6.1.11 kernel) for firmware_rev

[jaymzh]

Huh I don't see to be part of chef-infra-owners anymore. I'll need to get that fixed

[GeorgeWestwater]

Merge approved @jaymzh; please merge until we can fix the branch protection

[jaymzh]

Looks like the GHE migration yanked me out of the chef-infra-owners group, so the UI doesn't know I am allowed to approve. But I AM allowed to force the merge. So after talking to @GeorgeWestwater I'm forcing the merge, and they'll work on fixing groups.