Fix broken metrics, make perf tests optional #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test_status The info metric should only be used for storing labels and its value should always be 1 for joins to work properly.. https://www.robustperception.io/why-info-style-metrics-have-a-value-of-1/ Also fixes a bug where get_uptime_status was always retuning 0 since it wasnt being passed a string. Also remove labels which are exposed as metrics. This would have caused high cardinality in prometheus.
|
Hey @Jeff-SearchPilot , happy Friday. Very cool PR and fantastic that you fixed some bugs. I wonder if these appeared when we did the refactor for v1 🤔. I have some free time this evening so am hoping to get this merged and fix a could of the issues with CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for dumping this into 1 PR, please see each commit for individual changes.
I've been trying to use the collector in a more realistic environment today and found a few issues which this PR addresses..
status_cake_test_infometric is now correctly set to 1 instead of 0 (see here for why), the current "uptime" state is now exposed via a newstatus_cake_test_statusmetricget_test_historycallsYou can see that now the performance data showing correctly in grafana..
