fixed parsing of test data, added helm chart, added server port, updated logging #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
approved these changes
Sep 1, 2021
|
Hello @fbuchmeier-abi 👋 I'm so sorry that I missed this pull request. This looks great an i'm happy for it to be merged. Thank you for taking the time to contribute 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Craig,
I've made some updates to your status-cake-export that I'd like to contribute:
test_collector.pyto work with the updated StatusCake API (https://www.statuscake.com/api/Tests/Get%20All%20Tests.md)As a bonus, I've added our Helm Chart for Kubernetes as another example on how to deploy your app.
I'd welcome your feedback on this and if you have any questions let me know.
Best Regards,
Florian.