Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secondary gids and lifecycle hooks #109

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Fix secondary gids and lifecycle hooks #109

merged 8 commits into from
Feb 21, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Feb 21, 2022 •
edited
Loading

what

  • Fix secondary gids
  • Fix lifecycle hooks (thanks to @kevouellet)
  • Fix broken tests
  • Use local.enabled for all resources including outputs

why

  • Secondary gids now show up in the plan
  • Lifecycle hooks show up appropriately

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Feb 21, 2022
@nitrocode nitrocode marked this pull request as ready for review February 21, 2022 17:08
@nitrocode nitrocode requested review from a team as code owners February 21, 2022 17:08
@nitrocode
Copy link
Member Author

/test all

aknysh
aknysh reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update https://github.com/cloudposse/terraform-aws-efs/blob/master/LICENSE#L190

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode changed the title Fix secondary gids Fix secondary gids and lifecycle hooks Feb 21, 2022
@nitrocode
Copy link
Member Author

/test all

bridgecrew[bot]
bridgecrew bot reviewed Feb 21, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 1473179 - terraform fmt - 1 new error was added

Change details

Error ID Change Path Resource
BC_VUL_2 Added /test/src/go.sum undefined

@nitrocode nitrocode requested a review from aknysh February 21, 2022 18:14
@nitrocode nitrocode merged commit 234010c into master Feb 21, 2022
@nitrocode nitrocode deleted the fix-secondary-gids branch February 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@aknysh aknysh aknysh approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secondary CIDRS not getting populated
4 participants
@nitrocode @aknysh @kevouellet @cloudpossebot